add host_override to parent.config and other sni name fixes#12868
Merged
traeak merged 3 commits intoapache:masterfrom Mar 17, 2026
Merged
add host_override to parent.config and other sni name fixes#12868traeak merged 3 commits intoapache:masterfrom
traeak merged 3 commits intoapache:masterfrom
Conversation
bryancall
added
Parent Proxy
strategy
Parent Selection
Bug
and removed
Parent Proxy
labels
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Some docs on the new feature would be helpful! |
serrislew
reviewed
Feb 27, 2026
| ``host_override`` | ||
| One of the following values: | ||
|
|
||
| - ``true`` - Sets the host header of the request using the selected parent, including the SNI name to be used for any upstream TLS connection. Useful when a parent is another CDN that requires a correct SNI name. |
Contributor
There was a problem hiding this comment.
Ifpristine_host_hdr is set to 1, does this have precedence over it?
Contributor
Author
There was a problem hiding this comment.
the pristine host header looks like it applies during remap and cache lookup but not after, which is where the host_override kicks in. I'll look into it more closely.
Contributor
Author
|
[approve ci autest] |
serrislew
approved these changes
Mar 17, 2026
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Mar 18, 2026
* add host_override to parent.config and other sni name fixes * add documentation for host_override in parent.config, update strategies.yaml docs * add test using pristine_host_hdr setting --------- Co-authored-by: Brian Olsen <bolsen149@comcast.com> (cherry picked from commit 801e5be)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to sni name handling when using another CDN as parent.
This adds "host_override" to parent.config and has some fixes for the strategies handling of same option.